Downloading files

Clase 33 de 54 • Full Stack JavaScript with Sails.js

Christopher Schönfeldt

student•

Hello guys!
url.resolve(sails.config.custom.baseurl, '/api/v1/things/' + thing.id + '/photo'); throws an error. The error says “Parameter “url” must be a string, not undefined”.
I can view my photo in the browser, if I go to url “localhost:1337/api/v1/things/123/photo”.
My config/custom.js contains a variable baseurl and its on standard base address (http://localhost1337).

thing.id has the id of the thing.

Christopher Schönfeldt

student•

SOLUTION: simply typo error -.-
I wrote sails.config.custom.baseurl but it should be sails.config.custom.baseUrl
and voila, mysterious error is gone ^^

Mike USA

student•

I like what you did there (adding /photo) to your API. I already have a route that displays more details of the thing at /api/v1/things/:id and was trying to think of a better way; though, I am not uploading only one photo, but several photos for my thing.

Ho Tsz Him

student•

Anyone knows how to update the file? How to modify the file which I uploaded

Diego Forero

Team Platzi•

in this case you can not update file, you only can upload your file again.

Noitidart Saab

student•

When I go to /api/v1/thing/1 how to make it pop open a "download dialog" in the browser, rather than displaying it?

Mike USA

student•

You may need to change the mime type of the file to application/octet-stream instead of using the type that you stored

Morten Olsrud

student•

At about 14 minutes in this video, you are discussing deleting the unwanted data from the things so as to not expose sensitive or unneeded data. To do this, you loop over all the items.

Would it not be better to build an explicit new object to pass to the front-end? This way you won’t forget to delete new data added to the model that might be unwanted over the wire?

Morten Olsrud

student•

Something like this. Keep in mind that I’ve tried to optimise the array-assignment here by not having the array having to grow for each item added. This can have an impact when there are loads of items.

    let sanitizedThings = [];
    sanitizedThings.length = things.length;

    _.each(things, (thing, idx) => {
      let sanitizedThing = {
        id: thing.id,
        owner: thing.owner,
        label: thing.label,
        imageSrc: ''
      };
      sanitizedThings[idx] = sanitizedThing;
    });

Mike USA

student•

You could do that, or you could also specify your list of permitted properties and delete all keys in the object that aren't in that list. Given your example it might look something like:

const permittedParams = {
  label: true,
  id: true,
  owner: true,
  imageSrc: true
};

_.each(things, thing=>{
  // add new keys
  // ...
  // thing.password = 'should filter out!';  // unsafe (will be stripped)
  // thing.unsafeKey = 'should filter out!'; // unsafe (will be stripped)
  // thing.imageSrc = '/foo/bar.png';        // safe (will keep)

  // remove keys not explicitly permitted to pass to client
  Object.keys(thing).forEach(key=>{
    if (!permittedParams[key]){
      delete thing[key];
    }
  });
});

This isn't the most efficient way, but with few fields and few things it shouldn't matter. The benefits of operating on the source array/object is you don't have to allocate more memory for that holding array.

More Efficient Method

To make this more efficient, we can assume every object in thing is uniform and has a the same set of fields as other objects. Using that assumption, you would only need to detect non-permitted fields on the first thing and delete those fields of each subsequent thing:

const permittedParams = {
  label: true,
  id: true,
  owner: true,
  imageSrc: true
};

const insecureParams = {};

// find all bad keys
Object.keys(things[0]).forEach(key=>{
  if( !permittedParams[key] ){
    insecureParam[key]=true;
  }
});

_.each(things, thing=>{
  // add new keys
  // ...

  // remove keys not explicitly permitted to pass to client
  Object.keys(insecureParams).forEach(unsafeKey=>delete thing[unsafeKey]);
});

And of course, this could be made a hook/module.

Sebastien Desemberg

student•

Hi Mike, After this lesson I'm getting an error when lifting the app, "(node:14181) [DEP0124] DeprecationWarning: REPLServer.rli is deprecated" I'm struggling to get help on this issue. Furthermore, when I refresh my things page in the browser I get a similar error in the terminal "(node:14181) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated"

Sebastien Desemberg

student•

To add more to the above, when copy/paste the thing url: http://localhost:1337/api/v1/things/7 I get the below error.

(node:22142) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated error: Sending 500 ("Server Error") response: TypeError: Thing.findOne is not a function at Object.fn (/Users/sebastiendesemberg/Desktop/ration/api/controllers/things/download-photo.js:37:29)

Line 37 in download-photo is "var thing = await Thing.findOne({ id: inputs.id });"

Downloading files

Welcome to the course

Introduction and generalities

The technologies we are going to use

What we will build

Avoiding mistakes in our code

Github for our project

Installing platforms and dependencies

The essentials

Backend architecture

Frontend Architecture

ParasailsJS

Authentication and login

User Subscription

Sessions and Data Base

Password recovery

Email verification

Contact form

Managing payment information

Creating a new page

Making our page interactive

Creating a new model

Automatic testing

Creating a new action

Using Cloud SDK

Creating custom made functions

Personalization

Permissions

Friends with associations

Advanced queries and .populate

Modals

Ajax forms

Loading and error states

Putting it all together

Uploading backend file

Uploading frontend files

Downloading files

Your turn

Growth and monetization

Building a paywall

Recurrent payment subscriptions

Notifications

Invitations (Existing Users)

Invitations (New Users)

Unclaimed Accounts

Going live

SailsJS and NodeJS Settings

Application secutiry

Cloudflare and SSL Certifications

Using a platform as a service

Deploy to Heroku

Settings to send to production

Adding variables to Heroku

Data Base Settings

Before launching

Course Closure

Bonus content

Server-side rendering with EJS

Designing your frontend with Bootstrap 4

Understanding datastores

'Pure' APIs